From c1e82e78176b2a8dbbc18fde3a67320b894cb621 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9B=B9=E9=B9=8F=E9=A3=9E?= Date: Mon, 23 Mar 2026 10:14:35 +0800 Subject: [PATCH] =?UTF-8?q?refactor(controller):=20=E4=BC=98=E5=8C=96Norma?= =?UTF-8?q?lPGIController=E4=BB=A3=E7=A0=81=E9=80=BB=E8=BE=91?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 将包装类型比较改为基本类型比较以提高性能 - 移除多余的文档注释星号符号 - 使用orElse(null)替代get()方法并添加业务异常检查 - 修复lambda表达式中的格式问题 - 调整方法参数注释格式保持一致性 --- .../nflg/wms/admin/controller/NormalPGIController.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/nflg-wms-admin/src/main/java/com/nflg/wms/admin/controller/NormalPGIController.java b/nflg-wms-admin/src/main/java/com/nflg/wms/admin/controller/NormalPGIController.java index c2c2044d..30a192f7 100644 --- a/nflg-wms-admin/src/main/java/com/nflg/wms/admin/controller/NormalPGIController.java +++ b/nflg-wms-admin/src/main/java/com/nflg/wms/admin/controller/NormalPGIController.java @@ -223,7 +223,7 @@ public class NormalPGIController extends BaseController { .eq(WmsQrCodeMaster::getBarcodeCode, code.getCodeId()) .one(); VUtil.trueThrowBusinessError(Objects.isNull(qrCodeMaster)).throwMessage("无效码【" + code.getCodeId() + "】"); - if (qrCodeMaster.getPackagingType().equals(1)) { + if (qrCodeMaster.getPackagingType() == 1) { code.setCodeNum(BigDecimal.ZERO); List childCode = qrCodeMasterService.lambdaQuery() .eq(WmsQrCodeMaster::getParentBarcodeId, qrCodeMaster.getId()) @@ -557,7 +557,6 @@ public class NormalPGIController extends BaseController { /** * 收货直接入库的(未启用储位管理) - * * @return */ private void setPoReceiveByIn(SrmMaterialReceiptQO item, @@ -1260,7 +1259,8 @@ public class NormalPGIController extends BaseController { WmsPoReceiptItem item = receiptItems.stream() .filter(rit -> rit.getId().equals(qrCodeMaster.getReceiptItemId())) .findFirst() - .get(); + .orElse(null); + VUtil.trueThrowBusinessError(Objects.isNull(item)).throwMessage("未找到二维码对应的订单"); item.setInQty(item.getInQty().add(code.getNum())); item.setCrossQty(item.getCrossQty().add(code.getNum())); }); @@ -1285,7 +1285,7 @@ public class NormalPGIController extends BaseController { .filter(qit -> qit.getReceiptItemId().equals(item.getId())) .toList() .stream() - .map(qit->new InCostCenterBackSubmitItemQRQO() + .map(qit -> new InCostCenterBackSubmitItemQRQO() .setBinNo(item.getStorageLocation()) .setQrCode(qit.getBarcodeCode()) ) @@ -1397,7 +1397,7 @@ public class NormalPGIController extends BaseController { /** * 根据送货单单号和大码的ID获取到具体的物料信息 - * @param request id= 大码的ID + * @param request id= 大码的ID * @return */ @Deprecated