refactor(controller): 优化NormalPGIController代码逻辑
- 将包装类型比较改为基本类型比较以提高性能 - 移除多余的文档注释星号符号 - 使用orElse(null)替代get()方法并添加业务异常检查 - 修复lambda表达式中的格式问题 - 调整方法参数注释格式保持一致性
This commit is contained in:
parent
789f79cb09
commit
c1e82e7817
|
|
@ -223,7 +223,7 @@ public class NormalPGIController extends BaseController {
|
||||||
.eq(WmsQrCodeMaster::getBarcodeCode, code.getCodeId())
|
.eq(WmsQrCodeMaster::getBarcodeCode, code.getCodeId())
|
||||||
.one();
|
.one();
|
||||||
VUtil.trueThrowBusinessError(Objects.isNull(qrCodeMaster)).throwMessage("无效码【" + code.getCodeId() + "】");
|
VUtil.trueThrowBusinessError(Objects.isNull(qrCodeMaster)).throwMessage("无效码【" + code.getCodeId() + "】");
|
||||||
if (qrCodeMaster.getPackagingType().equals(1)) {
|
if (qrCodeMaster.getPackagingType() == 1) {
|
||||||
code.setCodeNum(BigDecimal.ZERO);
|
code.setCodeNum(BigDecimal.ZERO);
|
||||||
List<WmsQrCodeMaster> childCode = qrCodeMasterService.lambdaQuery()
|
List<WmsQrCodeMaster> childCode = qrCodeMasterService.lambdaQuery()
|
||||||
.eq(WmsQrCodeMaster::getParentBarcodeId, qrCodeMaster.getId())
|
.eq(WmsQrCodeMaster::getParentBarcodeId, qrCodeMaster.getId())
|
||||||
|
|
@ -557,7 +557,6 @@ public class NormalPGIController extends BaseController {
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* 收货直接入库的(未启用储位管理)
|
* 收货直接入库的(未启用储位管理)
|
||||||
*
|
|
||||||
* @return
|
* @return
|
||||||
*/
|
*/
|
||||||
private void setPoReceiveByIn(SrmMaterialReceiptQO item,
|
private void setPoReceiveByIn(SrmMaterialReceiptQO item,
|
||||||
|
|
@ -1260,7 +1259,8 @@ public class NormalPGIController extends BaseController {
|
||||||
WmsPoReceiptItem item = receiptItems.stream()
|
WmsPoReceiptItem item = receiptItems.stream()
|
||||||
.filter(rit -> rit.getId().equals(qrCodeMaster.getReceiptItemId()))
|
.filter(rit -> rit.getId().equals(qrCodeMaster.getReceiptItemId()))
|
||||||
.findFirst()
|
.findFirst()
|
||||||
.get();
|
.orElse(null);
|
||||||
|
VUtil.trueThrowBusinessError(Objects.isNull(item)).throwMessage("未找到二维码对应的订单");
|
||||||
item.setInQty(item.getInQty().add(code.getNum()));
|
item.setInQty(item.getInQty().add(code.getNum()));
|
||||||
item.setCrossQty(item.getCrossQty().add(code.getNum()));
|
item.setCrossQty(item.getCrossQty().add(code.getNum()));
|
||||||
});
|
});
|
||||||
|
|
@ -1285,7 +1285,7 @@ public class NormalPGIController extends BaseController {
|
||||||
.filter(qit -> qit.getReceiptItemId().equals(item.getId()))
|
.filter(qit -> qit.getReceiptItemId().equals(item.getId()))
|
||||||
.toList()
|
.toList()
|
||||||
.stream()
|
.stream()
|
||||||
.map(qit->new InCostCenterBackSubmitItemQRQO()
|
.map(qit -> new InCostCenterBackSubmitItemQRQO()
|
||||||
.setBinNo(item.getStorageLocation())
|
.setBinNo(item.getStorageLocation())
|
||||||
.setQrCode(qit.getBarcodeCode())
|
.setQrCode(qit.getBarcodeCode())
|
||||||
)
|
)
|
||||||
|
|
@ -1397,7 +1397,7 @@ public class NormalPGIController extends BaseController {
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* 根据送货单单号和大码的ID获取到具体的物料信息
|
* 根据送货单单号和大码的ID获取到具体的物料信息
|
||||||
* @param request id= 大码的ID
|
* @param request id= 大码的ID
|
||||||
* @return
|
* @return
|
||||||
*/
|
*/
|
||||||
@Deprecated
|
@Deprecated
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue